Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mTLS for JaegerRemoteSampler [java] #5209

Closed
chicobento opened this issue Feb 13, 2023 · 2 comments
Closed

Support mTLS for JaegerRemoteSampler [java] #5209

chicobento opened this issue Feb 13, 2023 · 2 comments
Labels
Feature Request Suggest an idea for this project help wanted

Comments

@chicobento
Copy link
Contributor

chicobento commented Feb 13, 2023

Background

Jaeger supports mTLS for GRPC interface via --query.grpc.tls.client-ca parameter.
However, JaegerRemoteSampleBuilder is not exposing the a setClientTls operation for setting the privateKey / certificate PEM, as done by other Builders, such as OtlpHttpSpanExporterBuilder.setClientTls.

Solution

Align JaegerRemoteSamplerBuilder with other Builders by providing a similar setClientTls operation.

Alternative
Ideally, all builders should also support ways for passing the key/trust store pairs rather than the raw pem files. In our solution we already have the general code for handling the conversion of pem files to keystore / truststore pairs done externally, so an overload of the setClientTls and setTrustedCertificates operations with the keystore/trustore params would come handy.
See #5211

@liangyuanpeng
Copy link

Seems like this issue can be closed.

@jack-berg
Copy link
Member

Resolved in #5209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project help wanted
Projects
None yet
Development

No branches or pull requests

4 participants