Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit to view's instrument selector #5334

Closed
asafm opened this issue Mar 29, 2023 · 2 comments
Closed

Add unit to view's instrument selector #5334

asafm opened this issue Mar 29, 2023 · 2 comments
Labels
Feature Request Suggest an idea for this project

Comments

@asafm
Copy link
Contributor

asafm commented Mar 29, 2023

Is your feature request related to a problem? Please describe.
OTel SDK Spec was modified to allow specifying a unit in the instrument selector: open-telemetry/opentelemetry-specification#3101

Describe the solution you'd like
Adding the ability in the SDK to specify a unit in a view's instrument selector.
@asafm asafm added the Feature Request Suggest an idea for this project label Mar 29, 2023
@asafm
Copy link
Contributor Author

asafm commented Mar 29, 2023

Once my design for Pulsar is approved, and no one has done it yet, I will do it.

@jack-berg
Copy link
Member

This was completed in #5255.

@asafm asafm mentioned this issue Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asafm @jack-berg