Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HttpTraceContext propagator #1102

Merged
merged 1 commit into from Apr 11, 2020
Merged

Fix HttpTraceContext propagator #1102

merged 1 commit into from Apr 11, 2020
+14 −6

Conversation

bogdandrutu
Copy link
Member

  • Check size first before accessing elements.

@bogdandrutu
Fix HttpTraceContext propagator
57b60fd 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1102 into master will not change coverage by %.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1102   +/-   ##
=========================================
  Coverage     85.58%   85.58%           
  Complexity     1085     1085           
=========================================
  Files           138      138           
  Lines          3990     3990           
  Branches        355      355           
=========================================
  Hits           3415     3415           
  Misses          434      434           
  Partials        141      141
Impacted Files Coverage Δ Complexity Δ
...ntelemetry/trace/propagation/HttpTraceContext.java 95.69% <83.33%> (ø) 23.00 <6.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aff51...57b60fd. Read the comment docs.

@jkwatson jkwatson merged commit e11344c into open-telemetry:master Apr 11, 2020
@carlosalberto carlosalberto mentioned this pull request Apr 14, 2020
Closed
davebarda pushed a commit to davebarda/opentelemetry-java that referenced this pull request Apr 24, 2020
@bogdandrutu @davebarda
Fix HttpTraceContext propagator (open-telemetry#1102)
20c3680 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@jkwatson jkwatson added this to the May Release milestone May 1, 2020
@bogdandrutu bogdandrutu deleted the fixw3c branch January 13, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson jkwatson approved these changes

@arminru arminru Awaiting requested review from arminru

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@songy23 songy23 Awaiting requested review from songy23

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bogdandrutu @codecov-io @jkwatson