Merge ViewRegistry and AggregationChooser #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
anuraaga,
arminru,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
bogdandrutu
force-pushed
the
mergeview
branch
from
1910bd7
to
3df2fd8
Compare
|
What's the motivation for this change? I had pulled it out into its own class to provide some separation of responsibilities, and to keep the individual classes small. |
I think the ViewManager right now was only a static method (from configuration to batcher(a.k.a processor)) so no reason to have it. I actually consider to move that logic later in the createProcessor. |
jkwatson
approved these changes
Dec 18, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
mergeview
branch
from
3df2fd8
to
747c9e6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2361