-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evict okhttp connections on shutdown #3921
evict okhttp connections on shutdown #3921
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3921 +/- ##
============================================
+ Coverage 89.87% 89.90% +0.02%
- Complexity 4174 4177 +3
============================================
Files 501 501
Lines 12753 12761 +8
Branches 1218 1218
============================================
+ Hits 11462 11473 +11
+ Misses 899 898 -1
+ Partials 392 390 -2
Continue to review full report at Codecov.
|
/easycla |
|
Ah also @svalaskevicius can you sign the CLA? |
Hi. Signed. The only issue with the cla form is that I think it requires way too much info from me for a single line change :D Eg I've used my email for the "mailing address" - IANAL, I hope it is OK (the form was accepted). I'll try to make another pr for the other place linked later when I'm back at laptop, but feel free to add it before I do :) |
Thanks @svalaskevicius! |
* evict okhttp connections on shutdown * Evict in HTTP exporter as well Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
fixes OkHttp thread not exiting on shutdown:
https://square.github.io/okhttp/4.x/okhttp/okhttp3/-ok-http-client/#shutdown-isnt-necessary
Fixes #3900