Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ConfigurableMetricExporterProvider to autoconfigure-spi #4478

Merged

Conversation

jack-berg
Copy link
Member

Now that metrics are stable we can stabilize the metric exporter provider SPI.

@jack-berg jack-berg requested a review from a user May 18, 2022 20:55
@jack-berg jack-berg requested a review from Oberon00 as a code owner May 18, 2022 20:55
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #4478 (98de65f) into main (dbe9a8e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4478      +/-   ##
============================================
- Coverage     90.12%   90.10%   -0.02%     
+ Complexity     5003     5002       -1     
============================================
  Files           569      569              
  Lines         15435    15435              
  Branches       1487     1487              
============================================
- Hits          13911    13908       -3     
- Misses         1061     1064       +3     
  Partials        463      463              
Impacted Files Coverage Δ
...entelemetry/exporter/jaeger/PostSpansResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...exporter/jaeger/MarshalerCollectorServiceGrpc.java 85.71% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe9a8e...98de65f. Read the comment docs.

@jkwatson jkwatson merged commit 8182129 into open-telemetry:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants