Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore prior histogram defaults #4717

Merged

Conversation

jack-berg
Copy link
Member

Builds on #4684. (Need to rebase after merging.)

Resolves #4699.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #4717 (a3dbe1a) into main (8445642) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##               main    #4717      +/-   ##
============================================
+ Coverage     90.62%   90.63%   +0.01%     
- Complexity     4901     4907       +6     
============================================
  Files           570      570              
  Lines         14730    14751      +21     
  Branches       1408     1413       +5     
============================================
+ Hits          13349    13370      +21     
+ Misses          957      953       -4     
- Partials        424      428       +4     
Impacted Files Coverage Δ
...ernal/aggregator/ExplicitBucketHistogramUtils.java 97.29% <94.44%> (-2.71%) ⬇️
...ernal/view/ExplicitBucketHistogramAggregation.java 100.00% <100.00%> (ø)
...gator/DoubleExplicitBucketHistogramAggregator.java 95.71% <0.00%> (-4.29%) ⬇️
...telemetry/sdk/common/InstrumentationScopeInfo.java 100.00% <0.00%> (ø)
...lemetry/sdk/internal/InstrumentationScopeUtil.java 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jack-berg jack-berg force-pushed the restore-prior-histogram-defaults branch from fcd3279 to 9efdb57 Compare August 24, 2022 18:05
@jack-berg jack-berg marked this pull request as ready for review August 24, 2022 18:05
@jack-berg jack-berg requested a review from a user August 24, 2022 18:05
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No real surprises and matches what we discussed.

@jack-berg jack-berg merged commit 160af1c into open-telemetry:main Aug 25, 2022
jack-berg added a commit to jack-berg/opentelemetry-java that referenced this pull request Sep 8, 2022
jack-berg added a commit that referenced this pull request Sep 8, 2022
* Revert "Restore prior histogram defaults (#4717)"

This reverts commit 160af1c.

* Revert "Update bucket hist defaults to match spec (#4684)"

This reverts commit 8445642.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config item to restore prior default histogram buckets
3 participants