-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LogExporter to LogRecordExporter #4773
Conversation
Codecov ReportBase: 90.76% // Head: 90.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4773 +/- ##
============================================
+ Coverage 90.76% 90.78% +0.02%
Complexity 4823 4823
============================================
Files 554 554
Lines 14374 14381 +7
Branches 1397 1397
============================================
+ Hits 13046 13056 +10
+ Misses 910 909 -1
+ Partials 418 416 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
longName.matches(".*SystemOutLogExporter.*".toRegex()) || | ||
longName.matches(".*OtlpJsonLoggingLogExporter.*".toRegex()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm interested to understand why these 2 are needed here even though they are in unstable artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those actually do live in stable artifacts. OtlpJsonLoggingLogExporter
lives opentelemetry-exporter-logging-otlp
, and SystemOutLogExporter
lives in opentelemetry-exporter-logging
.
Tedious but necessary because naming is important.
Related to #4714.