Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LogExporter to LogRecordExporter #4773

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

jack-berg
Copy link
Member

Tedious but necessary because naming is important.

Related to #4714.

@jack-berg jack-berg requested a review from a team as a code owner September 22, 2022 20:10
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 90.76% // Head: 90.78% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4bccbe7) compared to base (f7317c6).
Patch coverage: 97.14% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4773      +/-   ##
============================================
+ Coverage     90.76%   90.78%   +0.02%     
  Complexity     4823     4823              
============================================
  Files           554      554              
  Lines         14374    14381       +7     
  Branches       1397     1397              
============================================
+ Hits          13046    13056      +10     
+ Misses          910      909       -1     
+ Partials        418      416       -2     
Impacted Files Coverage Δ
...autoconfigure/spi/AutoConfigurationCustomizer.java 0.00% <ø> (ø)
.../autoconfigure/LogRecordExporterConfiguration.java 93.44% <83.33%> (ø)
...logging/otlp/OtlpJsonLoggingLogRecordExporter.java 80.00% <100.00%> (ø)
...y/exporter/logging/SystemOutLogRecordExporter.java 91.42% <100.00%> (ø)
...rter/otlp/http/logs/OtlpHttpLogRecordExporter.java 77.77% <100.00%> (ø)
...lp/http/logs/OtlpHttpLogRecordExporterBuilder.java 100.00% <100.00%> (ø)
.../exporter/otlp/logs/OtlpGrpcLogRecordExporter.java 77.77% <100.00%> (ø)
...er/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java 100.00% <100.00%> (ø)
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 94.66% <100.00%> (+0.03%) ⬆️
...sdk/autoconfigure/LoggerProviderConfiguration.java 92.59% <100.00%> (+0.92%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +81 to +82
longName.matches(".*SystemOutLogExporter.*".toRegex()) ||
longName.matches(".*OtlpJsonLoggingLogExporter.*".toRegex())
Copy link
Member

@trask trask Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm interested to understand why these 2 are needed here even though they are in unstable artifacts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those actually do live in stable artifacts. OtlpJsonLoggingLogExporter lives opentelemetry-exporter-logging-otlp, and SystemOutLogExporter lives in opentelemetry-exporter-logging.

@jack-berg jack-berg merged commit 9b17be3 into open-telemetry:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants