WIP: Comsume proto files from git submodule and build them in a separate module

[pavolloffay]

Resolves #232
Replaces #483
Depends on open-telemetry/opentelemetry-proto#26, after the merge I will change the GIT URL to point to the upstream.

WIP: because the git submodule is based on my fork of proto repository https://github.com/pavolloffay/opentelemetry-proto

Signed-off-by: Pavol Loffay ploffay@redhat.com

[pavolloffay]

@bogdandrutu @songy23 could you please have a look?

[songy23]

Configuration errors: 1 error occurred:

* In step 3 definition: Invalid step structure (expected string or map, got config.StepDescription)

Please fix.

[bogdandrutu]

These 2 can be defined in the libraries to be consistent with other dependencies.

[bogdandrutu]

If you rebase you will fix the android errors.

[carlosalberto]

+1. Not all the artifacts will use protobufVersion (i.e. the API itself), but this way we hopefully don't have to re-declare this version again and again ;)

[codecov-io]

Codecov Report

Merging #504 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #504      +/-   ##
============================================
- Coverage     78.55%   78.34%   -0.21%     
+ Complexity      561      560       -1     
============================================
  Files            65       65              
  Lines          1926     1926              
  Branches        188      188              
============================================
- Hits           1513     1509       -4     
- Misses          355      357       +2     
- Partials         58       60       +2

Impacted Files	Coverage Δ	Complexity Δ
...y/sdk/trace/export/BatchSampledSpansProcessor.java	89.77% <0%> (-2.28%)	6% <0%> (ø)
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java	98.79% <0%> (-1.21%)	55% <0%> (-1%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a15d3...e1bd471. Read the comment docs.

[pavolloffay]

I have submitted PR to proto repository to remove the gradle config and move files to the root directory open-telemetry/opentelemetry-proto#26

[pavolloffay]

@bogdandrutu I have marked this PR as WIP with depends on open-telemetry/opentelemetry-proto#26.

Since this is merged I will create an issue to change to upsream repo once it's ready

[songy23]

Can someone advice on how to do Gradle build locally after this change? I tried ./gradlew build on my workstation and Gradle complained about cannot find protos:

error: package io.opentelemetry.proto.trace.v1 does not exist
import io.opentelemetry.proto.trace.v1.Span;
...
30 errors
FAILURE: Build failed with an exception.

[bogdandrutu]

Use make

[songy23]

Cool that worked. Created #507 to reflect this change in CONTRIBUTING.md.