Update semconv to 1.19.0 and related build tool changes #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Mar 20, 2023
semconv/src/main/java/io/opentelemetry/semconv/resource/attributes/ResourceAttributes.java
Show resolved
Hide resolved
lmolkova
commented
Mar 20, 2023
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5311 +/- ##
============================================
+ Coverage 90.98% 90.99% +0.01%
Complexity 4900 4900
============================================
Files 551 551
Lines 14484 14494 +10
Branches 1369 1369
============================================
+ Hits 13178 13189 +11
Misses 907 907
+ Partials 399 398 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Show resolved
Hide resolved
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Show resolved
Hide resolved
semconv/src/main/java/io/opentelemetry/semconv/resource/attributes/ResourceAttributes.java
Show resolved
Hide resolved
lmolkova
force-pushed
the
build-tools-changes
branch
from
a5e5d96
to
1ab7807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of breaking changes in the spec in 1.19.0 along with changes in internal yaml structure and signal types.
Spec changes caused build-tool to break (open-telemetry/opentelemetry-specification#3299) and fix requires semconv generation script changes implemented in this PR and shown in open-telemetry/build-tools#157