Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.protobuf:protobuf-bom from 3.23.1 to 3.23.2 #5483

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 29, 2023

Bumps com.google.protobuf:protobuf-bom from 3.23.1 to 3.23.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner May 29, 2023 04:04
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 29, 2023
@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.protobuf-protobuf-bom-3.23.2 branch from 507357b to e78bb94 Compare May 30, 2023 17:59
@jack-berg
Copy link
Member

Looks like build is failing bc protobuf code gen changed again for jaeger remote sampler, similar to #5237. Will look into it later when we have a chance. Might have to add a permanent japicmp exception for the generated code. Could also pin jaeger remote sampler code gen to an old version of protobuf, but that will probably lead to vulnerabilities in the future which will force us to address the upgrade issues.

@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.protobuf-protobuf-bom-3.23.2 branch from e78bb94 to 6c2cccd Compare May 31, 2023 16:54
Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.23.1 to 3.23.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.23.1...v3.23.2)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.protobuf-protobuf-bom-3.23.2 branch from 6c2cccd to 7b0fb87 Compare May 31, 2023 16:54
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4850f47) 91.33% compared to head (9ea7126) 91.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5483      +/-   ##
============================================
- Coverage     91.33%   91.32%   -0.01%     
- Complexity     4891     4892       +1     
============================================
  Files           547      547              
  Lines         14410    14412       +2     
  Branches       1354     1354              
============================================
+ Hits          13161    13162       +1     
- Misses          865      866       +1     
  Partials        384      384              

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 7b86085 into main Jun 7, 2023
16 checks passed
@jack-berg jack-berg deleted the dependabot/gradle/com.google.protobuf-protobuf-bom-3.23.2 branch June 7, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant