Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationReader handles null values as empty #5829

Merged
merged 3 commits into from
Sep 15, 2023
Merged

ConfigurationReader handles null values as empty #5829

merged 3 commits into from
Sep 15, 2023

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Sep 13, 2023 •
edited
Loading

Resolves #5828.

@jack-berg jack-berg mentioned this pull request Sep 13, 2023
Merged
@jack-berg jack-berg mentioned this pull request Sep 13, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...sion/incubator/fileconfig/ConfigurationReader.java 100.00%

📢 Thoughts on this report? Let us know!.

@jack-berg jack-berg marked this pull request as ready for review September 14, 2023 13:51
@jack-berg jack-berg requested a review from a team as a code owner September 14, 2023 13:51
@jack-berg jack-berg merged commit 5d50936 into open-telemetry:main Sep 15, 2023
18 checks passed
@jaydeluca jaydeluca mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigurationFactory requires '{}' for keys when no configuration is present
2 participants
@jack-berg @mateuszrzeszutek