Stabilize MetricProducer, allow custom MetricReaders #5835
Conversation
| SdkMeterProvider.builder().registerMetricReader(OpenCensusMetrics.attachTo(reader)).build(); | ||
| SdkMeterProvider.builder() | ||
| .registerMetricReader(reader) | ||
| .registerMetricProducer(OpenCensusMetricProducer.create()) |
There was a problem hiding this comment.
This demonstrates how you would register a custom metric producer with SdkMeterProvider. Nice and tidy.
All the MetricData produced flow to any registered MetricReaders.
...cs/src/main/java/io/opentelemetry/sdk/metrics/internal/export/MultiMetricProducerReader.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
…y-java into stabilize-metric-producer
| @@ -60,7 +59,7 @@ public final class PrometheusHttpServer implements MetricReader { | |||
|
|
|||
| private final HttpServer server; | |||
| private final ExecutorService executor; | |||
| private volatile MetricProducer metricProducer = MetricProducer.noop(); | |||
| private volatile CollectionRegistration collectionRegistration = CollectionRegistration.noop(); | |||
There was a problem hiding this comment.
Is it currently possible to use the OC bridge with the Prometheus exporter?
There was a problem hiding this comment.
Sure - the OC metrics will go to any registered MetricReader. Built in MetricReaders include PrometheusHttpServer, PeriodicMetricReader (to support any push based MetricExporter), and InMemoryMetricReader for testing.
| SdkMeterProvider.builder().registerMetricReader(OpenCensusMetrics.attachTo(reader)).build(); | ||
| SdkMeterProvider.builder() | ||
| .registerMetricReader(reader) | ||
| .registerMetricProducer(OpenCensusMetricProducer.create()) |
…y-java into stabilize-metric-producer
|
@jkwatson can you take a look when you have a chance? |
API changes seem reasonable to me. 👍🏽 |
Resolves #5317. Resolves #5011.
Spec PR #3685 marked MetricProducer as stable, and was released in spec version 1.25.0.
The stabilization of MetricProducer was blocking custom MetricReaders, so now custom MetricReaders are supported as well.