Allow events to be emitted with timestamp #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 49 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
jack-berg
reviewed
Oct 19, 2023
api/events/src/main/java/io/opentelemetry/api/events/EventEmitter.java
Outdated
Show resolved
Hide resolved
jack-berg
reviewed
Oct 25, 2023
api/events/src/main/java/io/opentelemetry/api/events/DefaultEventEmitter.java
Outdated
Show resolved
Hide resolved
jack-berg
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several cases where events may need to be emitted with a timestamp that is different from "now" (the current time), the main ones being:
These are not contrived use cases. In Android, we have a specific need to track certain startup behaviors, and the sdk creation is not necessarily early enough in the application lifecycle to handle this.