Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception handling in TlsUtil#decodePem #6034

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jack-berg
Copy link
Member

Fixes #4533. As demonstrated in #6003, android desugaring now supports Base64.

@jack-berg jack-berg requested a review from a team as a code owner November 30, 2023 22:25
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14eaa4c) 91.16% compared to head (62b0349) 91.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6034      +/-   ##
============================================
+ Coverage     91.16%   91.18%   +0.01%     
  Complexity     5613     5613              
============================================
  Files           616      616              
  Lines         16564    16562       -2     
  Branches       1642     1642              
============================================
+ Hits          15101    15102       +1     
+ Misses         1013     1011       -2     
+ Partials        450      449       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah very cool, thank you!

@jack-berg jack-berg merged commit 40325e5 into open-telemetry:main Nov 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEM client TLS private key on Android
3 participants