Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize synchronous gauge #6419

Merged
merged 3 commits into from
May 9, 2024

Conversation

jack-berg
Copy link
Member

Synchronous gauges are now stable in the spec: open-telemetry/opentelemetry-specification#4019

Resolves #5795.

@jack-berg jack-berg requested a review from a team as a code owner May 1, 2024 16:23
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.90%. Comparing base (0d2d67e) to head (9608301).

Files Patch % Lines
.../opentelemetry/api/metrics/DoubleGaugeBuilder.java 0.00% 1 Missing ⚠️
...io/opentelemetry/api/metrics/LongGaugeBuilder.java 0.00% 1 Missing ⚠️
...a/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java 66.66% 1 Missing ⚠️
...ava/io/opentelemetry/sdk/metrics/SdkLongGauge.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6419      +/-   ##
============================================
- Coverage     90.92%   90.90%   -0.02%     
- Complexity     6165     6167       +2     
============================================
  Files           678      678              
  Lines         18453    18484      +31     
  Branches       1812     1813       +1     
============================================
+ Hits          16778    16803      +25     
- Misses         1141     1146       +5     
- Partials        534      535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/**
* Builds and returns a DoubleGauge instrument with the configuration.
*
* <p>NOTE: This produces a synchronous gauge which records gauge values as they occur. Most users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something about how only the most recent one is exported, since I think that part of synchronous gauges is most likely to trip people up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment to that effect.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit c7d472a into open-telemetry:main May 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add context overload to synchronous gauge API
4 participants