Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Span.Kind.INTERNAL as default. #94

Merged
merged 2 commits into from Apr 10, 2019
Merged

Use Span.Kind.INTERNAL as default. #94

merged 2 commits into from Apr 10, 2019

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Apr 10, 2019

Fixes #56.

SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to revisit accepting nullable span kind

api/src/main/java/openconsensus/trace/data/SpanData.java Outdated
@@ -76,6 +76,7 @@ public static SpanData create(
@Nullable Status status,
@Nullable Timestamp endTimestamp) {
Utils.checkNotNull(messageEvents, "messageEvents");
kind = kind == null ? Kind.INTERNAL : kind;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to accept nullable kind for SpanData?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we made SpanKind as an optional field before. After this change it may make more sense to make it required. Updated and removed the nullable annotation.

@songy23 songy23 merged commit 850f4bf into open-telemetry:master Apr 10, 2019
@songy23 songy23 deleted the span-kind-default branch April 10, 2019 17:03
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request May 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@songy23 @carlosalberto @SergeyKanzhelev