Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: release 1.0.4 #133

Merged
merged 1 commit into from
Dec 22, 2021
Merged

chore: release 1.0.4 #133

merged 1 commit into from
Dec 22, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2021

🤖 I have created a release *beep* *boop*

1.0.4 (2021-12-18)

Bug Fixes

  • align globalThis fallbacks with otel-core (#126) (3507de7)

This PR was generated with Release Please. See documentation.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2021

CLA Signed

The committers are authorized under a signed CLA.

@vmarchaud vmarchaud marked this pull request as draft November 8, 2021 09:00
@vmarchaud
Copy link
Member

I'm pretty sure we don't want to release only this change (plus cla is still broken :/ )

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #133 (353bd38) into main (633dbde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          42       42           
  Lines         578      578           
  Branches       94       94           
=======================================
  Hits          546      546           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633dbde...353bd38. Read the comment docs.

@vmarchaud
Copy link
Member

@dyladan Do we release 1.0.4 before merging others that should be a minor ?

@dyladan
Copy link
Member

dyladan commented Dec 16, 2021

@vmarchaud yes I would like to release this first. Why did you mark this as draft?

@vmarchaud
Copy link
Member

yes I would like to release this first. Why did you mark this as draft?

Because i guessed that we needed to wait for other changes so i wanted to avoid wasting time of other approvers to approve this

@vmarchaud vmarchaud marked this pull request as ready for review December 17, 2021 09:17
@vmarchaud vmarchaud requested a review from a team as a code owner December 17, 2021 09:17
@dyladan
Copy link
Member

dyladan commented Dec 22, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants