Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

feat: define common attributes type #142

Merged
merged 2 commits into from
Jan 8, 2022
Merged

feat: define common attributes type #142

merged 2 commits into from
Jan 8, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 16, 2021

As discussed in SIG, this creates a common definition for attributes which can be used by all signals.

Span attributes is marked as deprecated in favor of the new common attributes definition.

@dyladan dyladan added the enhancement New feature or request label Dec 16, 2021
@dyladan dyladan requested a review from a team as a code owner December 16, 2021 18:49
@codecov
Copy link

codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #142 (79b237a) into main (474f853) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   94.46%   94.47%           
=======================================
  Files          42       42           
  Lines         578      579    +1     
  Branches       94       94           
=======================================
+ Hits          546      547    +1     
  Misses         32       32
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474f853...79b237a. Read the comment docs.

Flarna
Flarna approved these changes Dec 16, 2021
View reviewed changes
src/common/Attributes.ts Show resolved Hide resolved
mwear
mwear approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we are marking SpanAttributes as deprecated, should we have a follow up task to replace usage with Attributes?

@dyladan dyladan mentioned this pull request Dec 16, 2021
Closed
legendecas
legendecas suggested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are already 3 approvals, mark the PR as changes requested to prevent accidental merging until we solve the questions.

@legendecas legendecas merged commit ae9bead into open-telemetry:main Jan 8, 2022
@dyladan dyladan deleted the common-attributes branch January 12, 2022 14:18
@dyladan dyladan mentioned this pull request Jan 20, 2022
Closed
@dyladan dyladan added this to the v1.1 milestone Jan 20, 2022
@legendecas legendecas mentioned this pull request May 31, 2022
Closed
@blumamir blumamir mentioned this pull request Apr 11, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Flarna Flarna Flarna approved these changes

@mwear mwear mwear approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@legendecas legendecas legendecas approved these changes

@blumamir blumamir blumamir approved these changes

@pirgeo pirgeo pirgeo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dyladan @mwear @vmarchaud @legendecas @Flarna @blumamir @pirgeo