feat(SugaredTracer): add draft of sugaredTracer #173
Conversation
Signed-off-by: secustor <sebastian@poxhofer.at>
| try { | ||
| const ret = fn(span); | ||
| // if fn is an async function attach a recordException and spanEnd callback to the promise | ||
| if (ret instanceof Promise) { |
There was a problem hiding this comment.
We don't generally brand check Promise in JavaScript. Typically, a duck-type checking like typeof ret.then === 'function' is preferred for thanables.
| return new SugaredTracer(tracer) | ||
| } | ||
|
|
||
| class SugaredTracer implements Tracer { |
There was a problem hiding this comment.
Bikeshedding: I'm not sure if this name is appropriate or comprehensible to users. But I didn't come up with a better name :(
There was a problem hiding this comment.
I have based the current iteration on the discussion in this issue, but I'm open for alternatives :)
There was a problem hiding this comment.
How about ConvenientSpanTracer or AutoClosingSpanTracer?
There was a problem hiding this comment.
AutoClosingSpanTracer: IMO this will not include only this feature, but could be expanded in the future. Therefore I think we should not use something specific like this.
ConvenientSpanTracer: Is fitting but, Sugared seems to be widely used for such scenarios.
|
@secustor this package is being moved into the main repo. Can you please re-apply this change there? I realize it isn't ideal, but it should at least get more attention there. |
Early draft of a SugaredTracer, intended as basis for discussions and implementation ideas.
cc @cartermp
Signed-off-by: secustor sebastian@poxhofer.at