Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: renaming noop span to non recording span #43

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 22, 2021

Fixes #41

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #43 (da4b1ae) into main (9fba460) will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          39       39           
  Lines         501      501           
  Branches       81       81           
=======================================
  Hits          474      474           
  Misses         27       27           
Impacted Files Coverage Δ
src/trace/NoopTracer.ts 95.45% <75.00%> (ø)
src/context/context.ts 92.50% <100.00%> (ø)
src/trace/NonRecordingSpan.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fba460...da4b1ae. Read the comment docs.

@Flarna
Copy link
Member

Flarna commented Apr 22, 2021

Should we add a Upgrade guidelines section in readme for breaking changes similar as in core repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename NoopSpan to NonRecordingSpan
4 participants