Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

feat: add function to wrap SpanContext in NonRecordingSpan #49 #51

Merged
merged 3 commits into from
Apr 28, 2021
Merged

feat: add function to wrap SpanContext in NonRecordingSpan #49 #51

merged 3 commits into from
Apr 28, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 27, 2021 •
edited
Loading

Fixes #49

@dyladan dyladan added enhancement New feature or request specification labels Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #51 (d8bb4b0) into main (b5784d3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   94.61%   94.65%   +0.04%     
==========================================
  Files          39       39              
  Lines         501      505       +4     
  Branches       81       81              
==========================================
+ Hits          474      478       +4     
  Misses         27       27
Impacted Files Coverage Δ
src/api/trace.ts 95.83% <100.00%> (+0.18%) ⬆️
src/trace/spancontext-utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5784d3...d8bb4b0. Read the comment docs.

@dyladan dyladan changed the title feat: add function to wrap SpanContext in NonRecordingSpan #50 feat: add function to wrap SpanContext in NonRecordingSpan #49 Apr 27, 2021
@dyladan dyladan mentioned this pull request Apr 27, 2021
Closed
Flarna
Flarna reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the new API also in setSpanContext

src/index.ts Outdated Show resolved Hide resolved
obecny
obecny approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmarchaud vmarchaud merged commit 324f197 into open-telemetry:main Apr 28, 2021
@dyladan dyladan deleted the wrap-span branch April 28, 2021 13:29
@dyladan dyladan mentioned this pull request May 17, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MSNev MSNev MSNev left review comments

@obecny obecny obecny approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

@johnbley johnbley Awaiting requested review from johnbley

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees
No one assigned
Labels
enhancement New feature or request specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spec] add trace#wrapSpanContext
5 participants
@dyladan @obecny @vmarchaud @Flarna @MSNev