Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

fix: enforce strict equality on prerelease versions #94

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 9, 2021

This PR prevents the API from accidentally accepting compatibility from e.g. 1.0.0 and 1.0.0-rc.3.

It is a requirement if we want the possibility of ever using canary releases.

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #94 (ac61ee8) into main (fda0e6b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head ac61ee8 differs from pull request most recent head 973c0ab. Consider uploading reports for the commit 973c0ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   94.84%   94.89%   +0.04%     
==========================================
  Files          42       42              
  Lines         563      568       +5     
  Branches       87       89       +2     
==========================================
+ Hits          534      539       +5     
  Misses         29       29              
Impacted Files Coverage Δ
src/internal/semver.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda0e6b...973c0ab. Read the comment docs.

src/internal/semver.ts Outdated Show resolved Hide resolved
src/internal/semver.ts Outdated Show resolved Hide resolved
@dyladan dyladan merged commit 3fdb88a into open-telemetry:main Jul 2, 2021
@dyladan dyladan deleted the strict-prerelease branch July 2, 2021 14:14
@dyladan dyladan changed the title chore: enforce strict equality on prerelease versions fix: enforce strict equality on prerelease versions Jul 28, 2021
@dyladan dyladan added bug Something isn't working and removed enhancement New feature or request labels Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants