fix: feedback

open-telemetry · Apr 16, 2024 · 744ea1d · 744ea1d
1 parent a2aaa4b
commit 744ea1d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/packages/opentelemetry-host-metrics/README.md b/packages/opentelemetry-host-metrics/README.md
@@ -47,18 +47,18 @@ Ref: [opentelemetry-js/issues/4235](https://github.com/open-telemetry/openteleme
 
 Metrics collected:
 
-| Metric                      | Short Description                                         | Notes |
-| --------------------------- | --------------------------------------------------------- | ----- |
-| `system.cpu.time`           | Seconds each logical CPU spent on each mode               |       |
-| `system.cpu.utilization`    | Difference in system.cpu.time since the last measurement  |       |
-| `system.memory.usage`       | Reports memory in use by state                            |       |
-| `system.memory.utilization` |                                                           |       |
-| `system.network.dropped`    | Count of packets that are dropped                         |       |
-| `system.network.errors`     | Count of network errors detected                          |       |
-| `system.network.io`         |                                                           |       |
-| `process.cpu.time`          | Total CPU seconds                                         |       |
-| `process.cpu.utilization`   | Difference in process.cpu.time since the last measurement |       |
-| `process.memory.usage`      | The amount of physical memory in use                      |       |
+| Metric                      | Short Description                                         |
+| --------------------------- | --------------------------------------------------------- |
+| `system.cpu.time`           | Seconds each logical CPU spent on each mode               |
+| `system.cpu.utilization`    | Difference in system.cpu.time since the last measurement  |
+| `system.memory.usage`       | Reports memory in use by state                            |
+| `system.memory.utilization` |                                                           |
+| `system.network.dropped`    | Count of packets that are dropped                         |
+| `system.network.errors`     | Count of network errors detected                          |
+| `system.network.io`         |                                                           |
+| `process.cpu.time`          | Total CPU seconds                                         |
+| `process.cpu.utilization`   | Difference in process.cpu.time since the last measurement |
+| `process.memory.usage`      | The amount of physical memory in use                      |
 
 Attributes collected:
 

diff --git a/packages/opentelemetry-host-metrics/src/enum.ts b/packages/opentelemetry-host-metrics/src/enum.ts
@@ -32,7 +32,7 @@ export enum ATTRIBUTE_NAMES {
   SYSTEM_CPU_STATE = 'system.cpu.state',
   SYSTEM_MEMORY_STATE = 'system.memory.state',
   SYSTEM_DEVICE = 'system.device',
-  NETWORK_NETWORK_DIRECTION = 'network.io.direction',
+  NETWORK_IO_DIRECTION = 'network.io.direction',
   SYSTEM_NETWORK_STATE = 'system.network.state',
   PROCESS_CPU_STATE = 'process.cpu.state',
 }

diff --git a/packages/opentelemetry-host-metrics/src/metric.ts b/packages/opentelemetry-host-metrics/src/metric.ts
@@ -151,7 +151,7 @@ export class HostMetrics extends BaseMetrics {
     networkUsages: Systeminformation.NetworkStatsData[]
   ): void {
     const deviceAttr = ATTRIBUTE_NAMES.SYSTEM_DEVICE;
-    const directionAttr = ATTRIBUTE_NAMES.NETWORK_NETWORK_DIRECTION;
+    const directionAttr = ATTRIBUTE_NAMES.NETWORK_IO_DIRECTION;
 
     for (let i = 0, j = networkUsages.length; i < j; i++) {
       const networkUsage = networkUsages[i];

diff --git a/packages/opentelemetry-host-metrics/test/metric.test.ts b/packages/opentelemetry-host-metrics/test/metric.test.ts
@@ -169,7 +169,7 @@ describe('Host Metrics', () => {
     const sysCpuNumAttr = ATTRIBUTE_NAMES.SYSTEM_CPU_LOGICAL_NUMBER;
     const sysMemStateAttr = ATTRIBUTE_NAMES.SYSTEM_MEMORY_STATE;
     const sysDeviceAttr = ATTRIBUTE_NAMES.SYSTEM_DEVICE;
-    const sysNetDirAttr = ATTRIBUTE_NAMES.NETWORK_NETWORK_DIRECTION;
+    const sysNetDirAttr = ATTRIBUTE_NAMES.NETWORK_IO_DIRECTION;
     const procCpuStateAttr = ATTRIBUTE_NAMES.PROCESS_CPU_STATE;
 
     it('should export CPU time metrics', async () => {