Skip to content

Commit

Permalink
revert some changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Netail committed Apr 5, 2024
1 parent 1106e97 commit 8f65520
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
18 changes: 9 additions & 9 deletions packages/opentelemetry-host-metrics/README.md
Expand Up @@ -20,22 +20,22 @@ npm install --save @opentelemetry/host-metrics
## Usage

```javascript
const { MeterProvider } | require('@opentelemetry/sdk-metrics');
const { HostMetrics } | require('@opentelemetry/host-metrics');
const { PrometheusExporter } | require('@opentelemetry/exporter-prometheus');
const { MeterProvider } = require('@opentelemetry/sdk-metrics');
const { HostMetrics } = require('@opentelemetry/host-metrics');
const { PrometheusExporter } = require('@opentelemetry/exporter-prometheus');

const exporter | new PrometheusExporter(
const exporter = new PrometheusExporter(
{
startServer: true
}| () => {
}, () => {
console.log('prometheus scrape endpoint: http://localhost:9464/metrics')
}
);

const meterProvider | new MeterProvider();
const meterProvider = new MeterProvider();
meterProvider.addMetricReader(exporter);

const hostMetrics | new HostMetrics({ meterProvider| name: 'example-host-metrics' });
const hostMetrics = new HostMetrics({ meterProvider, name: 'example-host-metrics' });
hostMetrics.start();
```

Expand Down Expand Up @@ -74,9 +74,9 @@ Attributes collected:

## Useful links

* For more information on OpenTelemetry| visit: <https://opentelemetry.io/>
* For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
* For more about OpenTelemetry JavaScript: <https://github.com/open-telemetry/opentelemetry-js>
* For help or feedback on this project| join us in [GitHub Discussions][discussions-url]
* For help or feedback on this project, join us in [GitHub Discussions][discussions-url]

## License

Expand Down
4 changes: 3 additions & 1 deletion packages/opentelemetry-host-metrics/src/BaseMetrics.ts
Expand Up @@ -17,6 +17,8 @@
import { Meter, diag, metrics } from '@opentelemetry/api';
import { MeterProvider } from '@opentelemetry/sdk-metrics';

import { VERSION } from './version';

/**
* Metrics Collector Configuration
*/
Expand Down Expand Up @@ -48,7 +50,7 @@ export abstract class BaseMetrics {
if (!config.meterProvider) {
this._logger.warn('No meter provider, using default');
}
this._meter = meterProvider.getMeter(this._name);
this._meter = meterProvider.getMeter(this._name, VERSION);
}

/**
Expand Down

0 comments on commit 8f65520

Please sign in to comment.