fix(mysql): metrics - align metrics description and unit to semconv (#…

…1480) Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
open-telemetry · May 1, 2023 · 9fbd9e8 · 9fbd9e8
1 parent 07c79ba
commit 9fbd9e8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/plugins/node/opentelemetry-instrumentation-mysql/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-mysql/src/instrumentation.ts
@@ -73,8 +73,8 @@ export class MySQLInstrumentation extends InstrumentationBase<
       'db.client.connections.usage', //TODO:: use semantic convention
       {
         description:
-          'The number of connections that are currently in the state referenced by the attribute "state".',
-        unit: '{connections}',
+          'The number of connections that are currently in state described by the state attribute.',
+        unit: '{connection}',
       }
     );
   }

diff --git a/plugins/node/opentelemetry-instrumentation-mysql/test/index.metrics.test.ts b/plugins/node/opentelemetry-instrumentation-mysql/test/index.metrics.test.ts
@@ -159,9 +159,9 @@ describe('mysql@2.x-Metrics', () => {
 
           assert.strictEqual(
             metrics[0].descriptor.description,
-            'The number of connections that are currently in the state referenced by the attribute "state".'
+            'The number of connections that are currently in state described by the state attribute.'
           );
-          assert.strictEqual(metrics[0].descriptor.unit, '{connections}');
+          assert.strictEqual(metrics[0].descriptor.unit, '{connection}');
           assert.strictEqual(
             metrics[0].descriptor.name,
             'db.client.connections.usage'
@@ -248,9 +248,9 @@ describe('mysql@2.x-Metrics', () => {
         assert.strictEqual(metrics[0].dataPointType, DataPointType.SUM);
         assert.strictEqual(
           metrics[0].descriptor.description,
-          'The number of connections that are currently in the state referenced by the attribute "state".'
+          'The number of connections that are currently in state described by the state attribute.'
         );
-        assert.strictEqual(metrics[0].descriptor.unit, '{connections}');
+        assert.strictEqual(metrics[0].descriptor.unit, '{connection}');
         assert.strictEqual(
           metrics[0].descriptor.name,
           'db.client.connections.usage'
@@ -325,9 +325,9 @@ describe('mysql@2.x-Metrics', () => {
 
           assert.strictEqual(
             metrics[0].descriptor.description,
-            'The number of connections that are currently in the state referenced by the attribute "state".'
+            'The number of connections that are currently in state described by the state attribute.'
           );
-          assert.strictEqual(metrics[0].descriptor.unit, '{connections}');
+          assert.strictEqual(metrics[0].descriptor.unit, '{connection}');
           assert.strictEqual(
             metrics[0].descriptor.name,
             'db.client.connections.usage'