Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency tedious to v16 #1521

Closed

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 26, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tedious 14.1.0 -> 16.4.0 age adoption passing confidence

Release Notes

tediousjs/tedious (tedious)

v16.4.0

Compare Source

Features

v16.3.0

Compare Source

Features

v16.2.0

Compare Source

Features

v16.1.0

Compare Source

Features

v16.0.0

Compare Source

chore
BREAKING CHANGES
  • Node.js 14.x is no longer supported by tedious.

v15.1.3

Compare Source

Bug Fixes

v15.1.2

Compare Source

Bug Fixes

v15.1.1

Compare Source

Bug Fixes

v15.1.0

Compare Source

Features

v15.0.1

Compare Source

Bug Fixes

v15.0.0

Compare Source

chore
  • drop support for Node.js 12 (121f3a5)
Features
  • change default value for trustServerCertificate option to false (04ebc29)
  • remove domain option for azure-active-directory-password authentication (85a2b89)
  • remove default value for clientId option of azure-active-directory-password authentication (8885e1f)
BREAKING CHANGES
  • The domain option was replaced by the tenantId option.
  • Using the azure-active-directory-password
    authentication type now requires specifying the clientId option of an
    Azure Application. The application has to have public client flows
    enabled and has to have user_impersonation permissions for Azure SQL
    Database. The user account that is being used also has to be assigned
    to the application, and has to grant consent (either explicitly or via
    admin consent).
  • The default value for the trustServerCertificate option
    changed from true to false.
  • tedious no longer supports Node.js 12.x.

v14.7.0

Compare Source

Features
  • support NTLM authentication on Node.js 17+ out of the box (#​1451) (318aacc)

v14.6.1

Compare Source

Bug Fixes

v14.6.0

Compare Source

Features
  • fail ntlm auth gracefully when md4 hashing is not available (#​1400) (57a50d4)

v14.5.0

Compare Source

Features
  • return aggregate errors (d8575b2)

v14.4.0

Compare Source

Features
  • add azure-active-directory-default as an authentication option (13ee60f)

v14.3.0

Compare Source

Features
  • rename domain to tenantId when using azure ad password (2150a9c)

v14.2.0

Compare Source

Features
  • allow specifying the clientId when using azure-active-directory-password auth (95e98a1)

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner May 26, 2023 00:43
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1521 (8512183) into main (4f11245) will decrease coverage by 4.50%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
- Coverage   96.06%   91.57%   -4.50%     
==========================================
  Files          14       49      +35     
  Lines         914     2432    +1518     
  Branches      199      442     +243     
==========================================
+ Hits          878     2227    +1349     
- Misses         36      205     +169     

see 35 files with indirect coverage changes

@renovate-bot renovate-bot force-pushed the renovate/tedious-16.x branch 2 times, most recently from 82c58e9 to 353ba67 Compare August 2, 2023 06:31
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to release notes of tedious

V16 breaking changes

drop node 14 support, add node 19 support (https://github.com/tediousjs/tedious/issues/1532) ([ef3fd2c](https://github.com/tediousjs/tedious/commit/ef3fd2cfe630e3765ad2429960dcc4e8b977769d))

This should probably also be fixed in the test suite here as well.

V15 breaking changes

BREAKING CHANGES
The domain option was replaced by the tenantId option.
Using the azure-active-directory-password
authentication type now requires specifying the clientId option of an
Azure Application. The application has to have public client flows
enabled and has to have user_impersonation permissions for Azure SQL
Database. The user account that is being used also has to be assigned
to the application, and has to grant consent (either explicitly or via
admin consent).
The default value for the trustServerCertificate option
changed from true to false.
tedious no longer supports Node.js 12.x.

I guess it's better for someone to check if one of these apply to the instrumentation.

We also need to update the versions range in tav.yml.

@forking-renovate
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@blumamir
Copy link
Member

Supporting tedious 16 requires fixing the tests in CI.
Documented in #1656 .

Closing current PR which is not mergeable

@blumamir blumamir closed this Aug 29, 2023
@forking-renovate
Copy link

forking-renovate bot commented Aug 29, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 16.x releases. But if you manually upgrade to 16.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/tedious-16.x branch August 29, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants