-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @types/node to v18.17.12 #1617
Conversation
ea7a293
to
d114225
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 139 139
Lines 7112 7112
Branches 1427 1427
=======================================
Hits 6527 6527
Misses 585 585 |
50aadd9
to
409bfa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but while we are at it, we should probably also align opentelemetry-resource-detector-container which depend on caret range.
@blumamir Hmm, I wonder if we even want to bump |
That's a good point. I guess it doesn't really matter either way.
If it was already agreed that's the way to go, then let's sync in contrib as well :) regardless of what we decide, we should align opentelemetry-resource-detector-container to match the rest of the repo. |
409bfa8
to
31ca4e0
Compare
31ca4e0
to
1f23917
Compare
1f23917
to
5d110a1
Compare
@pichlermarc I don't see any config in core repo to ignore If we do decide to pin it, what version should we use for pinning? Since we support node 14, shouldn't the type reference the oldest supported major version so it guards us from using new node features which are not supported in node 14? |
5d110a1
to
03a38e6
Compare
03a38e6
to
dd81efb
Compare
dd81efb
to
ab02609
Compare
ab02609
to
c4f9308
Compare
c4f9308
to
103f504
Compare
103f504
to
ad9c228
Compare
743ce58
to
7ce15c6
Compare
7ce15c6
to
337275b
Compare
replaced by #1653 |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update (18.17.12). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
18.16.19
->18.17.12
Configuration
π Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.