Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/node to v18.17.12 #1617

Closed

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 28, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) 18.16.19 -> 18.17.12 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner July 28, 2023 01:15
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1617 (337275b) into main (0fbacba) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         139      139           
  Lines        7112     7112           
  Branches     1427     1427           
=======================================
  Hits         6527     6527           
  Misses        585      585           

@renovate-bot renovate-bot force-pushed the renovate/node-18.x branch 2 times, most recently from 50aadd9 to 409bfa8 Compare August 2, 2023 11:28
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but while we are at it, we should probably also align opentelemetry-resource-detector-container which depend on caret range.

@pichlermarc
Copy link
Member

@blumamir Hmm, I wonder if we even want to bump @types/node if we don't need to. Possibly we should ignore it in the renovate config. πŸ€” I think in core we don't usually bump it.

@blumamir
Copy link
Member

blumamir commented Aug 3, 2023

@blumamir Hmm, I wonder if we even want to bump @types/node if we don't need to. Possibly we should ignore it in the renovate config. πŸ€”

That's a good point. I guess it doesn't really matter either way.
Bumping the version regularly will float issues faster, but it is also more ongoing work for us.

I think in core we don't usually bump it.

If it was already agreed that's the way to go, then let's sync in contrib as well :)

regardless of what we decide, we should align opentelemetry-resource-detector-container to match the rest of the repo.

@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.1 chore(deps): update dependency @types/node to v18.17.2 Aug 4, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.2 chore(deps): update dependency @types/node to v18.17.3 Aug 5, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.3 chore(deps): update dependency @types/node to v18.17.4 Aug 8, 2023
@blumamir
Copy link
Member

@blumamir Hmm, I wonder if we even want to bump @types/node if we don't need to. Possibly we should ignore it in the renovate config. πŸ€” I think in core we don't usually bump it.

@pichlermarc I don't see any config in core repo to ignore @types/node new versions, nor do I see relevant renovate PRs. What am I missing?

If we do decide to pin it, what version should we use for pinning? Since we support node 14, shouldn't the type reference the oldest supported major version so it guards us from using new node features which are not supported in node 14?

@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.4 chore(deps): update dependency @types/node to v18.17.5 Aug 11, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.5 chore(deps): update dependency @types/node to v18.17.6 Aug 18, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.6 chore(deps): update dependency @types/node to v18.17.7 Aug 22, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.7 chore(deps): update dependency @types/node to v18.17.8 Aug 22, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.8 chore(deps): update dependency @types/node to v18.17.9 Aug 23, 2023
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.9 chore(deps): update dependency @types/node to v18.17.11 Aug 25, 2023
@renovate-bot renovate-bot force-pushed the renovate/node-18.x branch 2 times, most recently from 743ce58 to 7ce15c6 Compare August 27, 2023 05:01
@renovate-bot renovate-bot changed the title chore(deps): update dependency @types/node to v18.17.11 chore(deps): update dependency @types/node to v18.17.12 Aug 28, 2023
@blumamir
Copy link
Member

replaced by #1653

@blumamir blumamir closed this Aug 28, 2023
@forking-renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (18.17.12). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/node-18.x branch August 28, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants