Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @cucumber/cucumber to v9 #1623

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 4, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@cucumber/cucumber ^8.8.0 -> ^9.0.0 age adoption passing confidence

Release Notes

cucumber/cucumber-js (@​cucumber/cucumber)

v9.3.0

Compare Source

Added
  • Support attachments with filenames (#​2297)
  • Support downloading attachments from HTML report (#​2300)

v9.2.0

Compare Source

Added
  • New option for JUnit test suite name to be passed in formatOptions (#​2265)
  • Include source reference in emitted messages for parameter types (#​2287)
Fixed
  • Correctly interpret retried scenarios in rerun formatter (#​2292)

v9.1.2

Compare Source

Changed
  • Only show global install warning in debug mode (#​2285)
Fixed
  • Export ISupportCodeLibrary type on /api entry point (#​2284)

v9.1.1

Compare Source

Fixed
  • Upgrade yaml to address security vulnerability (#​2281)

v9.1.0

Compare Source

Added
  • Formatters create sub-directory automatically instead of failing (#​2266)
  • Include a less cryptic error message when trying to require an ES module (#​2264)
Changed
  • Change hashes type from any to Record<string, string> in DataTable (#​2270)

v9.0.1

Compare Source

Fixed
  • Ensure feature paths are properly deduplicated (#​2258)

v9.0.0

Compare Source

Removed
  • BREAKING CHANGE: Remove support for Node.js versions 12 and 17 (#​2237)
  • BREAKING CHANGE: Remove "generator" snippet interface (#​2241)

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner August 4, 2023 01:16
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1623 (b911a98) into main (4f11245) will decrease coverage by 4.32%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
- Coverage   96.06%   91.74%   -4.32%     
==========================================
  Files          14      137     +123     
  Lines         914     7084    +6170     
  Branches      199     1426    +1227     
==========================================
+ Hits          878     6499    +5621     
- Misses         36      585     +549     

see 123 files with indirect coverage changes

@blumamir
Copy link
Member

From browsing the code, it seems cucumber already supports v 9 here, as well as tested in test all versions here.

So this PR is only about which version is the default one to use for npm test.
From npm:
image

It seems v 8 is still more popular, but not dramatically, and I assume it will change in the near future in favor of v9.
So I think it's a good idea to upgrade and test against 9 by default, while we do test both versions with tav

@blumamir blumamir merged commit 8802eae into open-telemetry:main Aug 11, 2023
13 of 14 checks passed
@renovate-bot renovate-bot deleted the renovate/cucumber-cucumber-9.x branch August 11, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants