-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: chore(deps): update mysql docker tag to v8 #1631
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
==========================================
- Coverage 91.75% 91.05% -0.71%
==========================================
Files 137 91 -46
Lines 7084 4728 -2356
Branches 1426 918 -508
==========================================
- Hits 6500 4305 -2195
+ Misses 584 423 -161 |
the service in github actions is defined like so:
And I need a way to pass the Another option is to mount a MySQL config file, as suggested here under "Using a custom MySQL configuration file":
This will require us to add a config file next to github workflows which isn't great. This option is not exposed as environment variable, as can be seen in MySQL environment variable docs. By using the command
While we need |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR was closed because it has been stale for 14 days with no activity. |
This is an attempt to apply the changes in this renovate PR: #1406 along with some necessary changes:
also update the image tag in test-utils and package.json that reference the old version
As described in details in this StackOverflow post:
Our tests uses native passwords, so obviously they couldn't connect. The new authentication method is not supported by
mysql
package, and old widely used versions ofmysql2
. I found that mysql8 can be run withmysql_native_password
by using the following flag when running docker:--default-authentication-plugin=mysql_native_password
.This PR is for applying relevant fixes to the renovate PR to use the new image tag.
The current image 5.7 has no docker image for Apple M2 chip on mac, therefore I am not even able to run current tests on my Mac.