fix: Update defect of of wrong resource attribute of "container.id"

[liurui-1]

Which problem is this PR solving?

As described in "#1677", the way to get resource attribute of "container.id" is wrong.

Short description of the changes

I made the changes following the code of OTel Java SDK which works well.
Here is the code I followed:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/resources/library/src/main/java/io/opentelemetry/instrumentation/resources/ContainerResource.java#L54-L60

I have tested the code working well in my Kubernetes environments.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: liurui-1 / name: Rui Liu (54e9fb4, 64bbf85, 533c46d, bb7afa3, 4c2a342)
• ✅ login: pichlermarc / name: Marc Pichler (f54e732)

[codecov]

Codecov Report

Merging #1682 (f54e732) into main (deb9aa4) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
- Coverage   91.77%   91.76%   -0.02%     
==========================================
  Files         139      139              
  Lines        7112     7125      +13     
  Branches     1427     1431       +4     
==========================================
+ Hits         6527     6538      +11     
- Misses        585      587       +2     

Files Changed	Coverage
...ector-container/src/detectors/ContainerDetector.ts	87.50%

[pichlermarc]

Thanks for fixing this! 🙂
Looks like the tests still need some attention as their current test data is not very realistic, so the new logic drops them.

Feel free to take the test-data from https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/0f1199620db05a3739cd3bae7e0c408a9bc0d65b/instrumentation/resources/library/src/test/java/io/opentelemetry/instrumentation/resources/CgroupV1ContainerIdExtractorTest.java#L82-L113 and adapt the tests here to use those. 🙂

[liurui-1]

Hello @pichlermarc , I updated the UT code. Please review again.

[liurui-1]

Hello, I updated the UT code. Please review again.

[pichlermarc]

Looks good, just missing some lint fixes it seems 🙂

[liurui-1]

@pichlermarc, I updated code according to the lint message. It seems the lint result does not show up automatically. Please help review.

[pichlermarc]

Thanks again for fixing this 🙂