Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for graphql-tools-executor #1706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YutaUra
Copy link

@YutaUra YutaUra commented Oct 1, 2023

Which problem is this PR solving?

  • Some GraphQL server libraries, such as graphql-yoga, use @graphql-tools/executor instead of graphql.js built-in executor.

Short description of the changes

  • Instrument @graphql-tools/executor

I have used the existing graphql.js excutor implementation as a reference, but if there is anything missing or incomplete in the testing or source code, I would be glad to hear about it.

@YutaUra YutaUra requested a review from a team as a code owner October 1, 2023 05:30
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 1, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: YutaUra / name: Yuta Ura (37e30a9)

@YutaUra YutaUra changed the title add support for graphql-tools-executor feat: add support for graphql-tools-executor Nov 8, 2023
@JamieDanielson
Copy link
Member

@YutaUra Sorry we have not had a chance to review this and it has been a while. Is this something you are still interested in, and would you be willing to be a maintainer of the instrumentation? This will be important to know before we can give this a thorough review. Thanks!

@phal0r
Copy link

phal0r commented Jun 4, 2024

Facing the same problem, it makes sense to have this instrumented aswell. Since these instrumentations are rather low-level it took hours to figure out, why the instrumentation did not work as expected.

@JamieDanielson
Copy link
Member

@YutaUra Sorry we have not had a chance to review this and it has been a while. Is this something you are still interested in, and would you be willing to be a maintainer of the instrumentation? This will be important to know before we can give this a thorough review. Thanks!

If it helps to understand why I ask, here is a link to some new guidance we've written about new instrumentations getting added to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants