Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept EventListener callbacks #175

Merged
merged 5 commits into from Oct 1, 2020
Merged

fix: accept EventListener callbacks #175

merged 5 commits into from Oct 1, 2020

Conversation

johnbley
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Add unit test showing the issue and a utility method to invoke a listener through its appropriate interface.

@johnbley johnbley requested a review from a team as a code owner August 18, 2020 16:33
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #175 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   95.19%   95.20%           
=======================================
  Files          92       92           
  Lines        4727     4731    +4     
  Branches      490      491    +1     
=======================================
+ Hits         4500     4504    +4     
  Misses        227      227           
Impacted Files Coverage Δ
...try-plugin-user-interaction/src/userInteraction.ts 94.04% <0.00%> (+0.09%) ⬆️

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the bug Something isn't working label Sep 7, 2020
@johnbley
Copy link
Member Author

@obecny @dyladan I'm guessing this fell through the cracks? Would be nice to have a merged fix for this.

@obecny obecny merged commit 7e9f1ae into open-telemetry:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants