Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump follow-redirects from 1.15.3 to 1.15.5 #1896

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 12, 2024

Bumps follow-redirects from 1.15.3 to 1.15.5.

Commits
  • b1677ce Release version 1.15.5 of the npm package.
  • d8914f7 Preserve fragment in responseUrl.
  • 6585820 Release version 1.15.4 of the npm package.
  • 7a6567e Disallow bracketed hostnames.
  • 05629af Prefer native URL instead of deprecated url.parse.
  • 1cba8e8 Prefer native URL instead of legacy url.resolve.
  • 72bc2a4 Simplify _processResponse error handling.
  • 3d42aec Add bracket tests.
  • bcbb096 Do not directly set Error properties.
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested a review from a team as a code owner January 12, 2024 16:08
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Merging #1896 (d5962f3) into main (3156c94) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1896   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         145      145           
  Lines        7427     7427           
  Branches     1486     1486           
=======================================
  Hits         6797     6797           
  Misses        630      630           

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/follow-redirects-1.15.5 branch from 0aec243 to 0d04cd3 Compare January 13, 2024 06:52
@blumamir
Copy link
Member

@open-telemetry/javascript-approvers - This PR updates a non-direct dependency in the lock file, for follow-redirects which seems to be used by dev or example dependencies like axios, and http-proxy which is a dependency of karma.

Having these kinds of PRs is too noisy and irrelevant IMO. Any thoughts on this subject?

@trentm
Copy link
Contributor

trentm commented Jan 17, 2024

Having these kinds of PRs is too noisy and irrelevant IMO. Any thoughts on this subject?

As best I know, we are still on the fence between using renovate or dependabot for dep updates -- so that is also adding to the noise.

This particular PR, I think counts as a "security update", so even if we (a) configured dependabot to group up a number of dependency updates into fewer PRs, and/or (b) configured dependabot to only update dependencies infrequently, this would still have been added as a separate PR.

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.5.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.5)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/follow-redirects-1.15.5 branch from 0d04cd3 to d5962f3 Compare January 17, 2024 19:52
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 29, 2024

Looks like follow-redirects is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jan 29, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/follow-redirects-1.15.5 branch January 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants