Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Host Telemetry: Option to filter Host/Process metrics #1946

Closed
wants to merge 2 commits into from
Closed

Conversation

marcsst
Copy link

@marcsst marcsst commented Feb 16, 2024

Which problem is this PR solving?

  • Running host-telemetry always adds 5 kinds of metrics (HostCPU, HostRAM, Network, ProcessCPU, ProcessRAM). Depending on your hardware this can add a lot of metrics you don't necessarily need.

Short description of the changes

  • This PR adds an optional meterScope setting that can be set to only return Host (HostCPU, HostRAM, Network) or Process (ProcessCPU, ProcessRAM) metrics as desired. To avoid breaking changes this setting can be left as undefined and will still return all.

@marcsst marcsst requested a review from a team as a code owner February 16, 2024 09:50
Copy link

linux-foundation-easycla bot commented Feb 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@marcsst marcsst changed the title Host Telemetry: Option to filter Host/Process metrics feat: Host Telemetry: Option to filter Host/Process metrics Feb 16, 2024
@pichlermarc
Copy link
Member

@marcsst these metrics can be dropped using the View feature of the SDK. Is that what you're looking for?

See https://opentelemetry.io/docs/languages/js/instrumentation/#configure-metric-views

@marcsst
Copy link
Author

marcsst commented Feb 19, 2024

@pichlermarc that looks exactly like what I needed >.> Thanks for pointing it out.

Marc

@marcsst marcsst closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants