Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instrumentation-perf-hooks): rename to instrumentation-runtime-node #1970

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

This is my proposal for the name change, see #1956

Short description of the changes

  • renames the entire package instrumentation-perf-hooks to instrumentation-runtime-node
  • this is not a breaking change as it has not been released yet
  • adds an entry in the component label map so that labels are applied

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #1970 (e2e9b4c) into main (e11f86e) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1970   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         146      146           
  Lines        7491     7491           
  Branches     1501     1501           
=======================================
  Hits         6819     6819           
  Misses        672      672           
Files Coverage Δ
...nstrumentation-runtime-node/src/instrumentation.ts 100.00% <100.00%> (ø)

@pichlermarc pichlermarc merged commit c00f529 into open-telemetry:main Feb 29, 2024
15 checks passed
@pichlermarc pichlermarc deleted the refactor/perf-hooks branch February 29, 2024 09:22
@trentm
Copy link
Contributor

trentm commented Mar 3, 2024

@pichlermarc Looking at this again, I suspect we want to change PerfHooksInstrumentation to RuntimeNodeInstrumentation or something.

@pichlermarc
Copy link
Member Author

pichlermarc commented Mar 4, 2024

@pichlermarc Looking at this again, I suspect we want to change PerfHooksInstrumentation to RuntimeNodeInstrumentation or something.

@trentm opened another PR #1989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants