-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-mongoose): Fix instrumentation for Mongoose Model methods, save() and remove(), by passing options argument to original method calls #2009
Merged
blumamir
merged 31 commits into
open-telemetry:main
from
ferrelucas:fix_mongoose_model_method_session_instrumentation
May 24, 2024
Merged
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6b7cf21
Fixing Mongoose instrumentation on Model methods with callback + tests
ferrelucas 2283303
Fixing and adding more tests
ferrelucas fac1251
Removing skip on existing failing test
ferrelucas f205174
Renaming callback index variable
ferrelucas 8aa008e
Merge branch 'open-telemetry:main' into fix_mongoose_model_method_ses…
ferrelucas ea60ff1
Merge branch 'open-telemetry:main' into fix_mongoose_model_method_ses…
ferrelucas 763a1a2
Merge branch 'open-telemetry:main' into fix_mongoose_model_method_ses…
ferrelucas adde5d2
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 1381823
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas d3294fe
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 57a9e9f
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 4a6a12b
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas d89bc0f
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 1361a24
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 95c1042
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 4d99a63
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 453f3a7
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 019d49d
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 0a2ffb3
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas d609e1f
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas a8219a1
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 784e99e
use exported strings for attributes
ferrelucas 7d3b460
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas 908b8af
Defining args as IArguments and updating its values directly
ferrelucas 7f12860
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
blumamir 1764acf
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
blumamir 8e9630f
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas cbce832
Fix lint issues
ferrelucas b6b04f7
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas b414324
Replacing tests with session option to use wtimeout to avoid the need…
ferrelucas a4336d3
Merge branch 'main' into fix_mongoose_model_method_session_instrument…
ferrelucas File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Note this replacer function was only introduced here to avoid an error due to the Session object having cyclical reference