-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(koa): Adds support to ignore a span by its layer name #2028
base: main
Are you sure you want to change the base?
Conversation
|
4623e18
to
47bed61
Compare
f41b872
to
a5b3a6e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
- Coverage 90.97% 90.42% -0.56%
==========================================
Files 146 148 +2
Lines 7492 7341 -151
Branches 1502 1528 +26
==========================================
- Hits 6816 6638 -178
- Misses 676 703 +27
|
882914e
to
57512e3
Compare
57512e3
to
d5e6c1d
Compare
d5e6c1d
to
5cb51b8
Compare
8e3b4df
to
fe52615
Compare
f0e8dd2
to
e2b7711
Compare
ff73355
to
1dce93d
Compare
882121f
to
f7565e7
Compare
f7565e7
to
8dfc847
Compare
8dfc847
to
99cd6ba
Compare
99cd6ba
to
0677d73
Compare
0677d73
to
23be73a
Compare
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
23be73a
to
12e6456
Compare
@blumamir can you help? |
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
87cb472
to
d7b359c
Compare
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
d7b359c
to
2f702fb
Compare
2f702fb
to
6485e10
Compare
Which problem is this PR solving?
ignoreLayersName
option to instrumentation constructor config to allow layers to be ignored by its name.ignoreLayersType
config, this new one will run after this check.Short description of the changes
KoaInstrumentationConfig
withignoreLayersName
which is an array ofstring
(layer names):isLayerNameIgnored
to check if a layer should be ignored by the name_patchLayer
to check if the layer is ignored by the config