Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(resource-detector-aws): update readme for aws resource detector #2060

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Mar 28, 2024

Which problem is this PR solving?

Short description of the changes

  • Update README of AWS Resource Detector to clarify the source of the data and add Semantic Conventions.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #2060 (51c6d6f) into main (dfb2dff) will decrease coverage by 0.16%.
Report is 37 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   90.97%   90.82%   -0.16%     
==========================================
  Files         146      148       +2     
  Lines        7492     7672     +180     
  Branches     1502     1537      +35     
==========================================
+ Hits         6816     6968     +152     
- Misses        676      704      +28     

see 8 files with indirect coverage changes

@maryliag maryliag force-pushed the doc-aws branch 3 times, most recently from 29f610e to a8620e7 Compare April 3, 2024 12:59
@maryliag maryliag changed the title chore: update readme for aws resource detector docs(resource-detector-aws): update readme for aws resource detector Apr 3, 2024
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I left a few nits around naming capitalization, but at a glance it seems really helpful. I don't know a ton about the attributes to confirm the descriptions.

maryliag and others added 3 commits April 9, 2024 09:19
Update README of AWS Resource Detector to clarifiy the source of the data and add Semantic Conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
@maryliag
Copy link
Contributor Author

maryliag commented Apr 9, 2024

updates made and also remove the notes column

@trentm trentm enabled auto-merge (squash) April 9, 2024 22:46
@trentm trentm merged commit 69e8077 into open-telemetry:main Apr 9, 2024
8 checks passed
@maryliag maryliag deleted the doc-aws branch April 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants