Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instrumentation-redis): Use exported semconv strings #2075

Merged
merged 5 commits into from Apr 17, 2024

Conversation

Zirak
Copy link
Contributor

@Zirak Zirak commented Apr 3, 2024

Which problem is this PR solving?

I was already in the Redis neighborhood with #2072 and thought to help out, thanks @JamieDanielson and @maryliag for prior work on this.

Short description of the changes

For @opentelemetry/instrumentation-redis:

  • Bump @opentelemetry/semantic-conventions to ^1.22.0
  • Rewire to use SEMATTR and DBSYSTEMVALUES constants
  • Add docs for which attributes the instrumentation sets

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #2075 (94eb8fa) into main (dfb2dff) will decrease coverage by 0.21%.
Report is 49 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2075      +/-   ##
==========================================
- Coverage   90.97%   90.77%   -0.21%     
==========================================
  Files         146      148       +2     
  Lines        7492     7675     +183     
  Branches     1502     1539      +37     
==========================================
+ Hits         6816     6967     +151     
- Misses        676      708      +32     
Files Coverage Δ
...e/opentelemetry-instrumentation-redis/src/utils.ts 93.10% <ø> (ø)

... and 8 files with indirect coverage changes

@maryliag
Copy link
Contributor

maryliag commented Apr 3, 2024

@Zirak looks like you're missing the changes on package-lock.json, can you run npm install on this package to have that file updated?

@Zirak
Copy link
Contributor Author

Zirak commented Apr 4, 2024

Of course, silly me! Thanks for the spot.

Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution :)

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@pichlermarc pichlermarc merged commit 0a0b4dc into open-telemetry:main Apr 17, 2024
13 checks passed
maryliag pushed a commit to maryliag/opentelemetry-js-contrib that referenced this pull request Apr 17, 2024
…elemetry#2075)

* refactor(instrumentation-redis): Use exported semconv strings

Part of open-telemetry#2025.

* chore(instrumentation-redis): Update package-lock

---------

Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants