Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instr-fastify): use exported strings for attributes #2078

Merged

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.HTTP_ROUTE with exported string SEMATTRS_HTTP_ROUTE
  • Update README with new semantic convention package version and key

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #2078 (853688e) into main (dfb2dff) will decrease coverage by 0.69%.
Report is 33 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
- Coverage   90.97%   90.29%   -0.69%     
==========================================
  Files         146      139       -7     
  Lines        7492     6891     -601     
  Branches     1502     1379     -123     
==========================================
- Hits         6816     6222     -594     
+ Misses        676      669       -7     
Files Coverage Δ
...try-instrumentation-fastify/src/instrumentation.ts 95.48% <100.00%> (ø)

... and 14 files with indirect coverage changes

@@ -17,7 +17,6 @@
// Use fastify from an ES module:
// node --experimental-loader=@opentelemetry/instrumentation/hook.mjs use-fastify.mjs

import { trace } from '@opentelemetry/api';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: this import was unused

@trentm trentm merged commit 1c9aec1 into open-telemetry:main Apr 3, 2024
17 checks passed
maryliag pushed a commit to maryliag/opentelemetry-js-contrib that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants