Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instr-router): use exported strings for attributes #2099

Merged

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.HTTP_ROUTE with exported string SEMATTRS_HTTP_ROUTE
  • Update README with new semantic convention package version and key

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #2099 (9051fd5) into main (dfb2dff) will decrease coverage by 0.21%.
Report is 50 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2099      +/-   ##
==========================================
- Coverage   90.97%   90.77%   -0.21%     
==========================================
  Files         146      148       +2     
  Lines        7492     7675     +183     
  Branches     1502     1539      +37     
==========================================
+ Hits         6816     6967     +151     
- Misses        676      708      +32     
Files Coverage Δ
...etry-instrumentation-router/src/instrumentation.ts 96.15% <100.00%> (ø)

... and 8 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 34796e2 into open-telemetry:main Apr 17, 2024
12 checks passed
@david-luna david-luna deleted the dluna/router-semconv-strings branch April 17, 2024 15:35
maryliag pushed a commit to maryliag/opentelemetry-js-contrib that referenced this pull request Apr 17, 2024
…emetry#2099)

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants