Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instr-knex): use exported strings for attributes #2109

Merged

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.* with exported strings SEMATTRS_*
  • Update README with new semantic convention package version and key

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #2109 (dd71376) into main (dfb2dff) will decrease coverage by 0.22%.
Report is 56 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   90.97%   90.76%   -0.22%     
==========================================
  Files         146      148       +2     
  Lines        7492     7675     +183     
  Branches     1502     1539      +37     
==========================================
+ Hits         6816     6966     +150     
- Misses        676      709      +33     
Files Coverage Δ
...emetry-instrumentation-knex/src/instrumentation.ts 98.78% <100.00%> (ø)
...de/opentelemetry-instrumentation-knex/src/utils.ts 90.24% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks like it's missing the update to package.json and package-lock.json 🙂

@david-luna
Copy link
Contributor Author

This one looks like it's missing the update to package.json and package-lock.json 🙂

Indeed! thanks for the heads up :)

@pichlermarc pichlermarc merged commit df2fa5a into open-telemetry:main Apr 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants