New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation-ioredis): use exported strings for attributes #2191
Conversation
Update to exported strings for Resource Attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
- Coverage 90.97% 90.47% -0.51%
==========================================
Files 146 149 +3
Lines 7492 7592 +100
Branches 1502 1591 +89
==========================================
+ Hits 6816 6869 +53
- Misses 676 723 +47
|
cmd.name, | ||
cmd.args | ||
), | ||
[SEMATTRS_DB_SYSTEM]: DbSystemValues.REDIS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This DbSystemValues
usage should be udpated as well, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -69,7 +69,7 @@ | |||
"dependencies": { | |||
"@opentelemetry/instrumentation": "^0.51.0", | |||
"@opentelemetry/redis-common": "^0.36.2", | |||
"@opentelemetry/semantic-conventions": "^1.0.0" | |||
"@opentelemetry/semantic-conventions": "^1.23.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This should be ^1.22.0
right?
"@opentelemetry/semantic-conventions": "^1.23.0" | |
"@opentelemetry/semantic-conventions": "^1.22.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just though if we are making an update, might as well update to the latest, so I did this on purpose. The message on readme says about 1.22+ to accommodate when this would happen.
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-instrumentation-ioredis
:@opentelemetry/semantic-conventions
^1.23.0