Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate "version update" in compile script #2224

Merged
merged 3 commits into from
May 22, 2024

Conversation

blumamir
Copy link
Member

Few packages had this content in package.json scripts:

"compile": "npm run version:update && tsc -p .",
"precompile": "tsc --version && lerna run version:update --scope @opentelemetry/foo --include-dependencies",

Since running the versions:update script is already part of the "precompile" script, there is no need to run it again in the compile. most packages in this repo are already written this way, and this PR aligns the remaining ones

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (dfb2dff) to head (3afc8b9).
Report is 133 commits behind head on main.

Current head 3afc8b9 differs from pull request most recent head cfa3a67

Please upload reports for the commit cfa3a67 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
- Coverage   90.97%   90.37%   -0.61%     
==========================================
  Files         146      147       +1     
  Lines        7492     7502      +10     
  Branches     1502     1571      +69     
==========================================
- Hits         6816     6780      -36     
- Misses        676      722      +46     

see 43 files with indirect coverage changes

@blumamir blumamir changed the title chore: remove duplicate version update in compile chore: remove duplicate "version update" in compile script May 18, 2024
@blumamir blumamir merged commit ec61892 into open-telemetry:main May 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment