Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ContainerId not detected post version 0.2.2 #2270

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

abhee11
Copy link
Contributor

@abhee11 abhee11 commented Jun 9, 2024

Which problem is this PR solving?

-#2073 (comment)

Short description of the changes

  • The (await this._getContainerIdV1()) ?? (await this._getContainerIdV2()) does not go in to v2 detector unless v1 return ull or defined - which in some cases returns '' which needs to be treated as falsy value

@abhee11 abhee11 requested a review from a team as a code owner June 9, 2024 06:07
@abhee11 abhee11 changed the title ?? only checks for null and undefined fix: containerId not detected post version 0.2.2 Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (dfb2dff) to head (e19422a).
Report is 155 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
- Coverage   90.97%   90.38%   -0.59%     
==========================================
  Files         146      149       +3     
  Lines        7492     7522      +30     
  Branches     1502     1576      +74     
==========================================
- Hits         6816     6799      -17     
- Misses        676      723      +47     
Files Coverage Δ
...ector-container/src/detectors/ContainerDetector.ts 92.85% <100.00%> (ø)

... and 53 files with indirect coverage changes

@abhee11 abhee11 changed the title fix: containerId not detected post version 0.2.2 fix: ContainerId not detected post version 0.2.2 Jun 9, 2024
@abhee11 abhee11 changed the title fix: ContainerId not detected post version 0.2.2 fix: ContainerId not detected post version 0.2.2 Jun 9, 2024
@pichlermarc pichlermarc merged commit 9761a91 into open-telemetry:main Jun 10, 2024
19 checks passed
@dyladan dyladan mentioned this pull request Jun 10, 2024
@abhee11 abhee11 deleted the fix/container-detector branch June 11, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants