Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency nyc to v17 #2279

Closed

Conversation

renovate-bot
Copy link
Contributor

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nyc (source) 15.1.0 -> 17.0.0 age adoption passing confidence
nyc (source) ^15.1.0 -> ^17.0.0 age adoption passing confidence

Release Notes

istanbuljs/nyc (nyc)

v17.0.0

Compare Source

⚠ BREAKING CHANGES
  • minimum Node version now 18
Bug Fixes
Build System
  • minimum Node version now 18 (9ef340e)

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (dfb2dff) to head (b222481).
Report is 164 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
- Coverage   90.97%   90.15%   -0.83%     
==========================================
  Files         146      147       +1     
  Lines        7492     7311     -181     
  Branches     1502     1569      +67     
==========================================
- Hits         6816     6591     -225     
- Misses        676      720      +44     

see 71 files with indirect coverage changes

@blumamir
Copy link
Member

From release notes:

⚠ BREAKING CHANGES
minimum Node version now 18

Not sure why the tests are green, but I think it's not safe to merge this one. at least not without reviewing the results of nyc which are already quite flaky.

I recommend to close this one and reconsider it again once we drop support for old node versions.

@pichlermarc
Copy link
Member

From release notes:

⚠ BREAKING CHANGES
minimum Node version now 18

Not sure why the tests are green, but I think it's not safe to merge this one. at least not without reviewing the results of nyc which are already quite flaky.

I recommend to close this one and reconsider it again once we drop support for old node versions.

Yep, I agree.

@pichlermarc pichlermarc closed this Jul 1, 2024
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 17.x releases. But if you manually upgrade to 17.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/nyc-17.x branch July 1, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:host-metrics pkg:id-generator-aws-xray pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:plugin-react-load pkg:propagation-utils pkg:propagator-instana pkg:propagator-ot-trace pkg:redis-common pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg:sql-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants