Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: metrics collector - proposition - ON HOLD #36

Closed
wants to merge 3 commits into from

Conversation

obecny
Copy link
Member

@obecny obecny commented May 21, 2020

Which problem is this PR solving?

Short description of the changes

  • Adds package to collect Metrics

FYI
Compiling packages works fine locally, compiling on circleCI and then installing from there is not yet done / wip

This is a proposition, naming conventions can be changed easily.

@obecny
Copy link
Member Author

obecny commented May 21, 2020

@mwear ^^

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #36 into master will increase coverage by 0.42%.
The diff coverage is 97.63%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   94.32%   94.74%   +0.42%     
==========================================
  Files          57       54       -3     
  Lines        3295     3749     +454     
  Branches      351      396      +45     
==========================================
+ Hits         3108     3552     +444     
- Misses        187      197      +10     
Impacted Files Coverage Δ
...es/opentelemetry-metrics-collector/src/stats/si.ts 88.88% <88.88%> (ø)
...pentelemetry-metrics-collector/src/stats/native.ts 90.00% <90.00%> (ø)
...ages/opentelemetry-metrics-collector/src/metric.ts 95.93% <95.93%> (ø)
...pentelemetry-metrics-collector/test/metric.test.ts 99.06% <99.06%> (ø)
...kages/opentelemetry-metrics-collector/src/cache.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-metrics-collector/src/enum.ts 100.00% <100.00%> (ø)
...pentelemetry-metrics-collector/src/stats/common.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-metrics-collector/src/util.ts 100.00% <100.00%> (ø)
node/opentelemetry-plugin-dns/src/version.ts
node/opentelemetry-plugin-redis/src/version.ts
... and 17 more

@dyladan
Copy link
Member

dyladan commented May 21, 2020

"collector" name is potentially confusing with the opentelemetry collector

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the naming issue and my comment, i'm okay merging this as-is.
However in the long term i hope that we can provide a lightweight alternative without C++ addon (which is hard to maintain), most metrics are accesible anyway from javascript.
Also i'm not a fan of systeminformations because of it rely on .exec` which spawn process which is quite performance costly.

"nyc": "^15.0.0",
"rimraf": "^3.0.2",
"sinon": "^7.5.0",
"systeminformation": "^4.23.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe systeminformation is needed at runtime for network metrics.

@obecny obecny changed the title chore: metrics collector - proposition chore: metrics collector - proposition - ON HOLD Jun 22, 2020
@obecny
Copy link
Member Author

obecny commented Jun 22, 2020

I'm keeping this on hold, as it needs anyway refactoring due to changes in metrics which are still either in review or waits for those in review and then few new to be implemented

@obecny
Copy link
Member Author

obecny commented Aug 31, 2020

refactored in new PR

@obecny obecny closed this Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants