Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Hapi Plugin to Instrumentation #380

Merged
merged 5 commits into from Mar 11, 2021
Merged

Moving Hapi Plugin to Instrumentation #380

merged 5 commits into from Mar 11, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Mar 4, 2021

Which problem is this PR solving?

Short description of the changes

  • Convert hapi plugin to instrumentation

@obecny obecny added the enhancement New feature or request label Mar 4, 2021
@obecny obecny self-assigned this Mar 4, 2021
@obecny obecny requested a review from a team as a code owner March 4, 2021 18:14
@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited

Codecov Report

Merging #380 (0e7ee76) into main (7a87f41) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          12       12           
  Lines         409      409           
  Branches       44       44           
=======================================
  Hits          384      384           
  Misses         25       25

Flarna
Flarna reviewed Mar 4, 2021
View reviewed changes
examples/hapi/package.json Outdated Show resolved Hide resolved
@obecny obecny merged commit 30d537f into open-telemetry:main Mar 11, 2021
@obecny obecny deleted the hapi branch March 11, 2021 16:29
@dyladan dyladan mentioned this pull request Mar 31, 2021
Closed
@nmiddendorff
Copy link

I just attempted to run the hapi example locally and had trouble resolving @opentelemetry/instrumentation-hapi. Does this need to switch back to @opentelemetry/hapi-instrumentation?

@obecny
Copy link
Member Author

obecny commented Apr 5, 2021

@opentelemetry/instrumentation-hapi hasn't been released yet

@Flarna
Copy link
Member

Flarna commented Apr 5, 2021

@nmiddendorff see #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@johnbley johnbley johnbley approved these changes

@Flarna Flarna Flarna approved these changes

Assignees

@obecny obecny

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert hapi plugin to instrumentation
5 participants
@obecny @nmiddendorff @Flarna @vmarchaud @johnbley