Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing broken links, updating to correct base url, replacing gitter with github discussions #395

Merged
merged 2 commits into from Mar 24, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Mar 23, 2021

more cleanups and fixes around links
removing gitter in favour of github discussions

@obecny obecny added the enhancement New feature or request label Mar 23, 2021
@obecny obecny self-assigned this Mar 23, 2021
@obecny obecny requested a review from a team as a code owner March 23, 2021 17:47
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #395 (0aed13c) into main (9aeec87) will increase coverage by 1.79%.
The diff coverage is n/a.

❗ Current head 0aed13c differs from pull request most recent head 9f5db32. Consider uploading reports for the commit 9f5db32 to get more accurate results

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   92.63%   94.43%   +1.79%     
==========================================
  Files           8       11       +3     
  Lines         285      431     +146     
  Branches       36       48      +12     
==========================================
+ Hits          264      407     +143     
- Misses         21       24       +3     
Impacted Files Coverage Δ
...propagator-ot-trace/test/OTTracePropagator.test.ts 100.00% <0.00%> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <0.00%> (ø)
...metry-propagator-ot-trace/src/OTTracePropagator.ts 95.83% <0.00%> (ø)

@dyladan
Copy link
Member

dyladan commented Mar 23, 2021

Can we add a task like this to the lint?

@obecny
Copy link
Member Author

obecny commented Mar 23, 2021

Can we add a task like this to the lint?

#396

@vmarchaud vmarchaud merged commit 694a0ea into open-telemetry:main Mar 24, 2021
@obecny obecny deleted the links branch March 24, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants